variable-length-quantity: add parameters to exercise placeholder #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameters to exercise placeholder for variable-length-quantity. Also changed variable naming from bytes to bytes_ to avoid shadowing python's bytes Fixes: exercism#651
ilya-khadykin
suggested changes
Oct 21, 2017
|
|
||
|
|
||
| def decode(): | ||
| def decode(bytes_): |
Contributor
There was a problem hiding this comment.
Why not just use bytes?
Could you please explain your reasoning?
I didn't get your point about shadowing
Contributor
Author
There was a problem hiding this comment.
In python 3.6, bytes() is a built-in function https://docs.python.org/3/library/functions.html#func-bytes, and I didn't want to shadow that built-in function.
In line with PEP8 I added a trailing underscore:
If a function argument's name clashes with a reserved keyword, it is generally better to append a single trailing underscore rather than use an abbreviation or spelling corruption. Thus class_ is better than clss. (Perhaps better is to avoid such clashes by using a synonym.)
ilya-khadykin
approved these changes
Oct 22, 2017
Contributor
|
Thanks, @ackerleytng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters to exercise placeholder for variable-length-quantity.
Also change variable naming from bytes to bytes_ to avoid shadowing
python's bytes
Fixes: #651