Skip to content

Add topics for 'Wordy' #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2017
Merged

Add topics for 'Wordy' #877

merged 2 commits into from
Oct 14, 2017

Conversation

miickel
Copy link
Contributor

@miickel miickel commented Oct 14, 2017 •
edited
Loading

closes #855

ilya-khadykin
ilya-khadykin suggested changes Oct 14, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR

Could please read my comment

config.json Outdated

"logic",
"parsing",
"pattern matching",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've switched to snake_case naming convention for topics to increase consistency among tracks, so could you please choose them from the following list - https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. I followed the convention used in the json-file, seems like there are mixed naming conventions in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miickel yeah, it's inconsistent, that's why we're encouraging people the list I provided above

@ilya-khadykin ilya-khadykin merged commit e75cc4b into exercism:master Oct 14, 2017
@ilya-khadykin
Copy link
Contributor

Thanks, @miickel

Just for future reference a guide of how to write good commit messages - https://chris.beams.io/posts/git-commit/#seven-rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wordy: add topics
2 participants
@miickel @ilya-khadykin