Skip to content

bob: add topics #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2017
Merged

bob: add topics #960

merged 2 commits into from
Oct 20, 2017

Conversation

mehul-m-prajapati
Copy link
Contributor

closes #811

ilya-khadykin
ilya-khadykin suggested changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Please read my comment

config.json Outdated

"strings",
"equality",
"control-flow (if-else statements)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to conditionals for consistency with https://github.com/exercism/problem-specifications/blob/master/TOPICS.txt

@ilya-khadykin ilya-khadykin merged commit bb1dc60 into exercism:master Oct 20, 2017
@ilya-khadykin
Copy link
Contributor

Thanks, @mehul-m-prajapati

It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃

@ilya-khadykin ilya-khadykin mentioned this pull request Oct 20, 2017
Closed
@mehul-m-prajapati mehul-m-prajapati deleted the bob-topics branch October 21, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bob: add topics
2 participants
@mehul-m-prajapati @ilya-khadykin