-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Hints on cryptography about "random" modules #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lucasloisp, I believe that the hints file should be located at Some of these exercises don't seem to require randomness, specifically:
I also wouldn't consider |
Noted! I've made the necessary updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
Please read my comment
@@ -0,0 +1,18 @@ | |||
# Hints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the file to hints.md
(lowercase) for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! I'd done it but apparently there was some error in renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@N-Parsons could you take a look?
@@ -0,0 +1,18 @@ | |||
# Hints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading level 1 here is going to be a the wrong level for the README - the first level in this document should be level 2 (##
). Personally, I would just delete this heading and keep the one below - two headings for one thing would seem strange in the flow of the README.
@@ -37,10 +37,6 @@ Bob calculates | |||
The calculations produce the same result! Alice and Bob now share | |||
secret s. | |||
|
|||
## Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README (and the one for simple-cipher
) will need either regenerating to include the hint. Alternatively, you can just copy-and-paste it in at this location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasloisp, the section needs to go before ### Submitting Exercises
, since that's where it goes if we regenerate the file.
@@ -0,0 +1,18 @@ | |||
# Hints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, I think like line should just be removed.
Adds HINTS file to "crypto-square" Adds HINTS file to "rail-fence-cipher" Adds HINTS file to "simple-cipher" Adds HINTS file to "rotational-cipher" Adds HINTS file to "robot-name" Takes recommendations into account
Closes #774 by creating a HINTS.md file for every exercise involving cryptography or the use of random module.
The wording is as follows