Clock: Canonical test improvements

Generated from x-common clock data

Now generates tests from data in x-common.

The template file is skinny, the generator a little fatter.

fixes #282
references exercism/problem-specifications#166

Author: kotp

exercises/clock/clock_test.rb

@@ -132,7 +132,7 @@ def test_add_across_midnight
     assert '00:01', Clock.at(23, 59) + 2
   end
 
-  def test_add_more_than_one_day__1500_min_is_equal_to_25_hrs_
+  def test_add_more_than_one_day__1500_min_is_equal_to_25_hrs
     skip
     assert '06:32', Clock.at(5, 32) + 1500
   end
@@ -172,7 +172,7 @@ def test_subtract_more_than_two_hours_with_borrow
     assert '03:35', Clock.at(6, 15) + -160
   end
 
-  def test_subtract_more_than_one_day__1500_min_is_equal_to_25_hrs_
+  def test_subtract_more_than_one_day__1500_min_is_equal_to_25_hrs
     skip
     assert '04:32', Clock.at(5, 32) + -1500
   end

exercises/clock/example.rb

@@ -5,12 +5,12 @@ def self.at(*args)
     Clock.new(*args)
   end
 
-  def initialize(hours = 0, minutes = 0)
+  def initialize(hours=0, minutes=0)
     @internal = hours * 60 + minutes
   end
 
   # rubocop:disable Style/OpMethod
-  def +(hours = 0, minutes)
+  def +(hours=0, minutes)
     @internal += hours * 60 + minutes
     self
   end

lib/clock_cases.rb

@@ -1,11 +1,13 @@
 class ClockCase < OpenStruct
   def name
-    'test_%s' % description.gsub(/[\(\) -]/, '_').gsub('=', 'is_equal_to')
+    'test_%s' % description
+                .gsub(/[() -]/, '_')
+                .gsub('=', 'is_equal_to')
+                .chomp('_')
   end
 
   def test_body
-    section == 'equal' &&
-      compare_clocks || simple_test
+    section == 'equal' ? compare_clocks : simple_test
   end
 
   def compare_clocks
@@ -27,11 +29,10 @@ def add_to_clock
   end
 
   def skipped
-    index > 0 && 'skip' || '# skip'
+    index.zero? ? '# skip' : 'skip'
   end
 end
 
-require 'pp'
 ClockCases = proc do |data|
   i = 0
   json = JSON.parse(data)