-
-
Notifications
You must be signed in to change notification settings - Fork 556
Clock exercise improvements #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The canonical test data was improved in this PR: #210 The clock.json is here: https://github.com/exercism/x-common/blob/master/clock.json |
This has the non-comparitive tests implemented from the changes implemented in the canonical changes introduced by @kytrinyx references #282 references exercism/problem-specifications#166
fixes #282 references exercism/problem-specifications#166
fixes #282 references exercism/problem-specifications#166
The json file has places where we modify by more than a day... but the problem comes when there is a unique situation where a parenthesised note shows up. Though it may be interesting that 1500 minutes is 25 hours, we really don't need to have that in the file that is meant to simplify the generation of tests. It complicates what we need to do in order to make valid test "titles" in some languages, or in using specific styles. |
fixes #282 references exercism/problem-specifications#166
Generated from x-common clock data Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Generated from x-common clock data Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Generated from x-common clock data Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Generated from x-common clock data Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Generated from x-common clock data Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Now generates tests from data in x-common. The template file is skinny, the generator a little fatter. fixes #282 references exercism/problem-specifications#166
Agreed--I'm fine with ditching the parentheses in the descriptions. |
it's not useful (there is no action for us to take) to leave this issue open. However, individuals interested in how tracks should keep up-to-date with problem-specifications should look at #524 . Note that the situation has gotten a lot better since the days of this issue, since the JSON file has a version now. |
I've been reviewing a lot of submissions for the Go implementation of Clock, and I'm seeing a few interesting edge cases:
I think that we should have test cases that go much father outside of the valid values, and I also think that we should test equality after adding values.
The text was updated successfully, but these errors were encountered: