pig-latin: generate tests using canonical data #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insti
approved these changes
Apr 21, 2017
exercises/pig-latin/example.tt
Outdated
| require_relative 'pig_latin' | ||
|
|
||
| # Common test data version: <%= abbreviated_commit_hash %> | ||
| class PigLatinTest < Minitest::Test<% test_cases.each do |test_case| %> |
There was a problem hiding this comment.
Add a newline here to split the class definition from the template code.
There was a problem hiding this comment.
Blech. ERB. Adding a newline here causes formatting problems in the generated test file.
There was a problem hiding this comment.
I believe you can use a backslash to avoid that? There is also something in ERB itself that lets you ignore the new line.
Minor thing though though.
The generated file being exemplar is more important.
lib/pig_latin_cases.rb
Outdated
| JSON.parse(data)['cases']. | ||
| flat_map {|section| section['cases'] }. | ||
| each_with_index. | ||
| reduce([]) {|cases, (test, i)| cases << PigLatinCase.new(test.merge('index' => i)) } |
There was a problem hiding this comment.
This is a bit of a mega code pipeline.
I wonder is it possible to add some intention revealing variable names into the mix.
Insti
approved these changes
Apr 21, 2017
|
Thank you @hilary ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
rake test