Skip to content

Phone number unit test not conforming to README (and neither to NANP) #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcoesposito1988 opened this issue Jun 22, 2017 · 1 comment
Labels
good first issue An improvement or bug fix that favors new contributors

Comments

@marcoesposito1988
Copy link

The README states (correctly according to the NANP format that the first digit of the Area and Exchange codes should be in the range 2-9 (so excluding 0 and 1).

However, the unit tests do not conform to this: invalid numbers (e.g. 1234567890) are supposed to be recognized as valid to pass the test. The example solution also does not conform.

Should I create a pull request with a correction or am I getting confused?

@petertseng
Copy link
Member

You're absolutely right.

The options for the pull request are:

Since you asked, you get to take the first pick of which of these options to take. If you would not, then other interested parties may as well.

@petertseng petertseng added the good first issue An improvement or bug fix that favors new contributors label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An improvement or bug fix that favors new contributors
Projects
None yet
Development

No branches or pull requests

2 participants