Skip to content

phone-number: Remove test using malformed input. #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2017
Merged

phone-number: Remove test using malformed input. #772

merged 2 commits into from
May 6, 2017

Conversation

Insti
Copy link
Contributor

@Insti Insti commented May 5, 2017

Your task is to clean up differently formated telephone numbers by removing punctuation and the country code (1) if present.

Letters are not punctuation and this is not primarily a string parsing exercise.
So remove the test using 1a2b3c4d5e6f7g8h9i0j as input.

Insti added 2 commits May 5, 2017 08:10
@Insti
Remove test on malformed data.
9259c82 
This is not a string parsing exercise and there is no reason why a
number should be invalid due to inconsequential non-digit characters.

"2a2b3c4d5e6f7g8h9i0j" should be as valid as: "My phone number is: 223 456 7890"
@Insti
Update version.
440eb2f
@Insti Insti merged commit 39cba0d into exercism:master May 6, 2017
@Insti Insti deleted the Phone_number_fix branch May 6, 2017 14:46
@Insti
Copy link
Contributor Author

Insti commented May 6, 2017

Thanks for the reviews. 👍

@m-dango m-dango mentioned this pull request May 6, 2017
Merged
@petertseng petertseng mentioned this pull request May 9, 2017
Merged
@petertseng petertseng mentioned this pull request Jun 23, 2017
Closed
emcoding pushed a commit that referenced this pull request Nov 19, 2018
@kotp
Merge pull request #772 from Insti/Remove_Issue_Template
29967ef 
meta: Remove issue template.
ZapAnton added a commit to ZapAnton/rust that referenced this pull request Nov 20, 2018
@ZapAnton
phone-number: Updated the exercise to the 1.6.1 version
b007852 
Relevant PRs:
- exercism/problem-specifications#772
- exercism/problem-specifications#1090
- exercism/problem-specifications#1120
- exercism/problem-specifications#1327
- exercism/problem-specifications#1337
- exercism/problem-specifications#1361
@ZapAnton ZapAnton mentioned this pull request Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behrtam behrtam behrtam approved these changes

@stkent stkent stkent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Insti @behrtam @stkent