phone-number, scale-generator: use range::contains#1036
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 21, 2020
petertseng:rangecontain
Merged
phone-number, scale-generator: use range::contains#1036petertseng merged 1 commit intoexercism:masterfrom petertseng:rangecontain
petertseng merged 1 commit intoexercism:masterfrom
petertseng:rangecontain
Conversation
I'm honestly not really convinced by the phone-number one but I guess it's one fewer mention of number_len so it's fine. https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
coriolinus
approved these changes
Nov 21, 2020
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
As you say, the phone-number one is a little weird, but might as well resolve the warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm honestly not really convinced by the phone-number one but I guess
it's one fewer mention of number_len so it's fine.
https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains