Skip to content

tournament: rm output files #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2016
Merged

tournament: rm output files #154

merged 1 commit into from
Jul 3, 2016

Conversation

petertseng
Copy link
Member

@petertseng petertseng commented Jul 2, 2016

With these output files present, implementation that do not actually
write files will be able to pass the tests, defeating the purpose. See
PR #153 for an example of such a lazy implementation.

They were added in 65b691e in what I
can only assume was an accident, since they were added long after the
tournament exercise was added to this track in
ee0a6fd.

With these output files present, implementation that do not actually
write files will be able to pass the tests, defeating the purpose. See
PR #153 for an example of such a lazy implementation.

They were added in 65b691e in what I
can only assume was an accident, since they were added long after the
tournament exercise was added to this track in
ee0a6fd.
@petertseng
Copy link
Member Author

Yes, I know #152 also removes these files, but this PR is meant to be pretty uncontroversial, whereas #152 could be controversial. The intent is to get this one out to be quickly mergeable while we discuss #152.

@IanWhitney
Copy link
Contributor

I'm fine with this.

@petertseng petertseng merged commit 29fcc66 into exercism:master Jul 3, 2016
@petertseng petertseng deleted the tournament-rm-output branch July 3, 2016 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants