Add implementation of custom-set exercise #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be slightly different from other tracks' custom set exercises as I've adapted the exercise to fit in with how the current sets in the rust base lib work.
pminten
added a commit
that referenced
this pull request
Oct 12, 2014
(Adding at the top for purely git technical reasons, #19 also modifies this file and I hope to avoid a (fairly trivial) merge conflict.)
| } | ||
|
|
||
| fn difference(a: Vec<uint>, b: Vec<uint>) -> Vec<uint> { | ||
| make_set(a).difference(&make_set(b)).map(|n| n.clone()).collect() |
There was a problem hiding this comment.
This requires that the iterator for set return the result in-order.
There was a problem hiding this comment.
Good catch, thanks.
|
Fixed issues pointed to by @etrepum. Thanks for the review. |
pminten
added a commit
that referenced
this pull request
Oct 15, 2014
Add implementation of custom-set exercise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be slightly different from other tracks' custom set exercises as I've
adapted the exercise to fit in with how the current sets in the rust base lib
work.
The example.rs has become quite large (260 lines) even though the conceptual complexity is fairly low (most of the tricky stuff is in DiffIter and insert, the rest is fairly straightforward).
Would appreciate a code review on this one, maybe I'm making some stuff more complicated than it needs to be.