Skip to content

Use example.rs specific Cargo.toml file during CI #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

ijanos
Copy link
Contributor

@ijanos ijanos commented Nov 20, 2016

Add support for optional Cargo-example.toml files to satisfy the CI and do not pollute the empty project config file. See discussion in #225

One thing I could not figure out though: where is it defined what files the CLI tool will download? Do I have to modify anything else to prevent the download of Cargo-examle.toml?

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think this is exactly what we want. I am still traveling, so take the opinion with a grain of salt, but the change is small enough that I can feel pretty confident.

@petertseng
Copy link
Member

petertseng commented Nov 20, 2016

One thing I could not figure out though: where is it defined what files the CLI tool will download? Do I have to modify anything else to prevent the download of Cargo-examle.toml?

This is all that is necessary. It just needs to have example in its path. This is defined in https://github.com/exercism/trackler/blob/master/lib/trackler/implementation.rb#L9 .

@kytrinyx , I've heard this question twice already, and I wonder if others will have it too. any place where we can make the answer more visible?

@IanWhitney
Copy link
Contributor

Nice. Thanks much, @ijanos!

@IanWhitney IanWhitney merged commit a3cae07 into exercism:master Nov 21, 2016
@ijanos ijanos deleted the test_examples branch November 21, 2016 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants