config: Ignore description.md and metadata.yml #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were created for #248, but since they're not in the ignore_pattern they are being served. See for proof: http://x.exercism.io/v2/exercises/rust/luhn-from http://x.exercism.io/v2/exercises/rust/luhn-trait And note how description.md and metadata.yml appear inside the response.
Insti
approved these changes
May 9, 2017
petertseng
commented
May 9, 2017
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "slug": "rust", | |||
| "language": "Rust", | |||
| "ignore_pattern": "example|description.md|metadata.yml", | |||
There was a problem hiding this comment.
fun fact: this will match a file name descriptionxmd, but we have no files of that name, so I don't care. it will go away if files move to .meta.
There was a problem hiding this comment.
another fun fact: When you need to put a backslash in json string you need two, so the correct regex still looks odd.
"ignore_pattern": "example|description\\.md|metadata\\.yml"
There was a problem hiding this comment.
another fun fact: the ignore_pattern is not anchored so you'll also match the_description.md_file_contains_the_description
petertseng
added a commit
to Insti/xrust
that referenced
this pull request
May 19, 2017
This reverts commit 230b91a. Since the previous commit removes the duplicate files, there is no more need to ignore them! The new copies (exercism#285) are in the .meta directory, which is always ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were created for #248, but since they're not in the ignore_pattern
they are being served.
See for proof:
http://x.exercism.io/v2/exercises/rust/luhn-from
http://x.exercism.io/v2/exercises/rust/luhn-trait
And note how description.md and metadata.yml appear inside the response.