Skip to content

travis: Enforce that stubs compile, supporting commit (add unimplemented) #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2017
Merged

travis: Enforce that stubs compile, supporting commit (add unimplemented) #372

merged 2 commits into from
Oct 28, 2017

Conversation

petertseng
Copy link
Member

@petertseng petertseng commented Oct 27, 2017 •
edited
Loading

travis: Enforce that stubs compile

Adding a stub with an incorrect signature would be confusing to
students. We will prevent that with CI.

Was desired in #339 (comment)

Closes #371.

@petertseng petertseng changed the title check-exercises: Enforce that stubs compile travis: Enforce that stubs compile, Move lib/src.rs check to separate script, supporting commits Oct 28, 2017
@petertseng
Copy link
Member Author

I had to expand this to have more. Individual commit messages explain.

@petertseng
Copy link
Member Author

Sorry, but I am unable to effectively do my duties as a track maintainer (review others' PRs) without this being merged, so if I can't get a review in 24 hours I have to just test it myself and merge if it passes my own tests.

@petertseng petertseng changed the title travis: Enforce that stubs compile, Move lib/src.rs check to separate script, supporting commits travis: Enforce that stubs compile, Move lib/src.rs check to separate script Oct 28, 2017
@petertseng petertseng changed the title travis: Enforce that stubs compile, Move lib/src.rs check to separate script travis: Enforce that stubs compile, supporting commit (add unimplemented) Oct 28, 2017
@petertseng
Copy link
Member Author

OK, split up the other changes into other PRs.

@coriolinus
Copy link
Member

Looks generally good to me!

I think we'll need to add a .meta/ALLOWED_TO_NOT_COMPILE exception to the decimal exercise and possibly others before merging; I don't think that we want to have this new check cause existing exercises to fail.

@petertseng
Copy link
Member Author

decimal is the only exercise that needs it.

@petertseng
add unimplemented to stubs
bb86c0a 
Otherwise, the actual return type of the stubs do not match their
declared return type and thus the stub does not compile.
@petertseng
travis: Enforce that stubs compile
60dbf21 
Adding a stub with an incorrect signature would be confusing to
students. We will prevent that with CI.

Was desired in #339 (comment)

Closes #371.
@petertseng petertseng merged commit ddd2a26 into exercism:master Oct 28, 2017
@petertseng petertseng deleted the check-stubs branch October 28, 2017 19:19
This was referenced Mar 20, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertseng @coriolinus