Add macro implementation exercise #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes exercism#397. This exercise requires that students implement a `hashmap!` macro to simplify creation of hashmap literals. The intent is to gently introduce macros-by-example by having them implement a macro which is both simple but useful. The [maplit crate](https://crates.io/crates/maplit) which inspired this exercise uses the [MIT license](https://opensource.org/licenses/MIT), which as far as I can tell permits this derivative use of its code. Used first edition book link in the readme because second edition's macros chapter is not yet written.
ijanos
approved these changes
Nov 28, 2017
petertseng
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
I hope I do not disappoint by saying there is nothing I would change. Maybe one thing about the description, but nothing about the exercise code. Feel free to take the suggestion or not.
In an ideal world, I would attempt to complete this exercise myself before approving it, but that will not be possible.
| @@ -0,0 +1,30 @@ | |||
|
|
|||
There was a problem hiding this comment.
I feel like this extra line could go, unless it is very important to have two newlines after the title
exercises/macros/README.md
Outdated
| @@ -0,0 +1,71 @@ | |||
| # Macros | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
(which will cause this newline to go too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397.
This exercise requires that students implement a
hashmap!macroto simplify creation of hashmap literals. The intent is to gently
introduce macros-by-example by having them implement a macro which
is both simple but useful.
The maplit crate which inspired
this exercise uses the MIT license,
which as far as I can tell permits this derivative use of its code.
Used first edition book link in the readme because second edition's
macros chapter is not yet written.