Skip to content

Updated pig-latin README #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Updated pig-latin README #467

merged 1 commit into from
Mar 16, 2018

Conversation

Baelyk
Copy link
Contributor

@Baelyk Baelyk commented Mar 16, 2018

Resolves #453:

I updated the README for the pig-latin exercise to correspond to the template in problem-specifications.

The update was discussed in the problem-specifications repo here.

@petertseng
Copy link
Member

petertseng commented Mar 16, 2018

Thank you for this change. This is suitable.

Please include one of the words in https://help.github.com/articles/closing-issues-using-keywords/ when referencing #453, otherwise we may forget to close it and we do not want to forget.

Your link to exercism/problem-specifications#1171 (https://github.com/exercism/problem-specifications/pull/1171) is appreciated. Please amend the commit message so that it is in the commit message, so that one can see this without having to use GitHub (e.g. if I do not have an internet connection).

The update was discussed in the problem-specifications repo in pr exercism#1171: pig-latin improve documentation

exercism/problem-specifications#1171
@Baelyk
Copy link
Contributor Author

Baelyk commented Mar 16, 2018

Like so?

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

I believe this change is uncontroversial (since CI is checking it for us) and obviously desirable (given the issue) so it is safe to merge it speedily.

@petertseng petertseng added the sync/readme Keep a README in sync with exercism/problem-specifications label Mar 16, 2018
@petertseng petertseng merged commit aee3d5d into exercism:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sync/readme Keep a README in sync with exercism/problem-specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants