Skip to content

README: minor typos #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2018
Merged

README: minor typos #578

merged 1 commit into from
Jul 20, 2018

Conversation

xakon
Copy link
Contributor

@xakon xakon commented Jul 16, 2018

No description provided.

@coriolinus
Copy link
Member

@xakon Thanks for contributing this! Unfortunately, this will break our CI if you just make the changes here. Before I merge this, it will be necessary to update the problem specifications repo. Are you willing to also open a PR there?

@ZapAnton
Copy link
Contributor

Is it the text from config/exercise_readme.go.tmpl?

Shouldn't it be enough to update the file and run configlet generate?

@coriolinus
Copy link
Member

@ZapAnton Good catch! Yes, I'd missed the origin of that particular text. @xakon please disregard my previous; we can handle this within this repo. Steps to finish this:

  1. Update config/exercise_readme.go.tmpl to fix the typos in the template.
  2. Ensure bin/configlet exists; if not, run bin/fetch-configlet to get it.
  3. Run bin/configlet generate . from the project root to regenerate all exercise readmes to fix the issue everywhere.

@xakon
Copy link
Contributor Author

xakon commented Jul 18, 2018

Hello!

Yes, @coriolinus, I would happily make a PR to the problem specification repo. I didn't know in the beginning how the whole process is being set, my apologies on that. On the other hand, it is a good opportunity for me to get introduced to it!

@xakon
Copy link
Contributor Author

xakon commented Jul 18, 2018

Based on the instructions of @coriolinus, I updated the template README. As a result, the typos are propagated to all exercises. Unfortunately, the PR has become huge now!

@xakon xakon changed the title pythagorean-triplet: minor typos in README REAME: minor typos Jul 18, 2018
Copy link
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the size; this sort of changeset is pretty easy to review. Thanks for doing this work @xakon!

Assuming Travis passes, the next step will be for this to sit for a while to give other track maintainers time to review this. Unless there are objections, I'll merge this not later than Friday the 20th. If on Saturday I still haven't, please feel free to ping me a reminder.

@coriolinus coriolinus changed the title REAME: minor typos README: minor typos Jul 18, 2018
@coriolinus coriolinus merged commit 9b4fd16 into exercism:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants