wordy: Added template to the stub file #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yes, I think so. At the time I wrote #444 (comment) I was thinking strings for the E in |
|
Done |
petertseng
reviewed
Aug 4, 2018
exercises/wordy/src/lib.rs
Outdated
|
|
||
| pub fn answer(&self) -> Option<i32> { | ||
| unimplemented!( | ||
| "Return the result of the transmitted command, or an error, if the command is invalid." |
There was a problem hiding this comment.
I think this should talk about None instead of error, now, right?
I'll prefer that change be amended into the Result -> Option commit so all the necessary changes for Result->Option are in one commit. It's small enough that amending won't cause a review burden.
coriolinus
approved these changes
Aug 4, 2018
There was a problem hiding this comment.
Thanks for implementing this, @ZapAnton! Assuming the wording change is made and there are no other maintainer objections, I'll merge this not later than Wednesday.
exercises/wordy/src/lib.rs
Outdated
|
|
||
| pub fn answer(&self) -> Option<i32> { | ||
| unimplemented!( | ||
| "Return the result of the transmitted command, or an error, if the command is invalid." |
ZapAnton
force-pushed
the
wordy_template
branch
from
2b2fc48 to
1b5f0d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to the #551
The returned type of the
WordProblem::answerfunction isResult<i32, String>, but perhapsOption<i32>is more suited here?