Skip to content

nth-prime: Add missing test case and change function signature #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abo64 opened this issue Dec 8, 2016 · 2 comments · Fixed by #238
Closed

nth-prime: Add missing test case and change function signature #231

abo64 opened this issue Dec 8, 2016 · 2 comments · Fixed by #238

Comments

@abo64
Copy link
Contributor

abo64 commented Dec 8, 2016

Test case "there is no zeroth prime" is missing in our test suite.
And then it makes sense to change Prime.nth to return an Option[Int] instead of just Int.

While being at it: Perhaps also change all other test descriptions to be the same as in canonical-data.json?

On a side note: There are more exercises out of sync with x-common. How can we handle this? There is an issue on the Haskell track for this.

@abo64 abo64 added the question label Dec 8, 2016
@ErikSchierboom
Copy link
Member

I agree with all you suggestions.

As for how to make exercises sync, that's actually a hard problem. Maybe all tracks maintainers should automatically receive a notification when the canonical data of an exercise is changed?

@abo64
Copy link
Contributor Author

abo64 commented Dec 8, 2016

Yes, that would be a good idea.
I would even say when the description.md changes.
And also when a new exercise is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants