Skip to content

Add protein-translation exercise #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2017
Merged

Conversation

ricemery
Copy link
Member

New Pull Request for the protein-translation exercise.

  • Removed Option from the method signature.
  • Lower difficulty to 3 and removed Optional Value from topics.

test("Identifies cysteine codons") {
pending
ProteinTranslation.translate("UGU") should be(Seq("Cysteine"))
ProteinTranslation.translate("UGU") should be(Seq("Cysteine"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the same as the line above it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

test("Identifies tryptophan codons") {
pending
ProteinTranslation.translate("UGG") should be(Seq("Tryptophan"))
ProteinTranslation.translate("UGG") should be(Seq("Tryptophan"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the same as the line above it.

@ricemery
Copy link
Member Author

Thanks @ErikSchierboom - I fixed the duplicate assertions in the test suite.

@abo64 abo64 merged commit 41bb8f5 into exercism:master May 16, 2017
@abo64
Copy link
Contributor

abo64 commented May 16, 2017

Thank you @ricemery

@ricemery ricemery deleted the prot-trans branch June 5, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants