Skip to content

Create PalindromeProductsTestGenerator.scala. Update PalindromeProduc… #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2017
Merged

Create PalindromeProductsTestGenerator.scala. Update PalindromeProduc… #460

merged 1 commit into from
Sep 27, 2017

Conversation

ricemery
Copy link
Member

  • Create PalindromeProductsTestGenerator.scala.
  • Update PalindromeProductsTest.scala. Note that I am including comments in the test suite to point out how the return types are used. The return types are fairly complicated..
  • Update example.scala to return Option from functions.
  • Update config.json to add Optional Values to topics for PalindromeProducts.

Refs #370, #331

ErikSchierboom
ErikSchierboom approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra comments!

@ErikSchierboom ErikSchierboom merged commit a885621 into exercism:master Sep 27, 2017
@ricemery
Copy link
Member Author

Thanks @ErikSchierboom

@ricemery ricemery deleted the palindrome branch September 27, 2017 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricemery @ErikSchierboom