Skip to content

Exercise "Wordy": README.md doesn't exactly match tests #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antonshevyrin opened this issue Jan 2, 2018 · 2 comments
Closed

Exercise "Wordy": README.md doesn't exactly match tests #130

antonshevyrin opened this issue Jan 2, 2018 · 2 comments

Comments

@antonshevyrin
Copy link

In README.md the following is written:

If you'd like, handle exponentials.
> What is 2 raised to the 5th power?

But in wordy.tests.ts:

  xit('too advanced', () => {
    const question = 'What is 53 cubed?'
    const problem  = new WordProblem(question)

    expect(problem.answer.bind(problem)).toThrowError( ArgumentError )
  })

README.md doesn't say anything about implementing unary operations. I understand that handling exponentials is considered as optional but in my opinion it is still a bit confusing when tests are so different from description.

@masters3d
Copy link
Contributor

I am not sure I follow. Do you have a proposed solution? Feel free to submit a PR. Thanks for your contribution.

@antonshevyrin
Copy link
Author

@masters3d
Actually after some investigations I found that this topic was already discussed before: exercism/problem-specifications#738
And it is decided that tests shouldn't cover optional extensions.
This issue must be closed then. Sorry for wrong report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants