Skip to content

Clarify mutation is allowed in high-scores #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SleeplessByte merged 2 commits into from
Aug 5, 2019
Merged

Clarify mutation is allowed in high-scores #1195

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e142136
Clarify mutation is allowed in high-scores
Jul 29, 2019
757285e
Provided examples of solutions that mutate
Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tracks/python/exercises/high-scores/mentoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ Another variation of this solution includes the start at -1 for slicing the resu
return sorted(scores)[-1:-4:-1]
```

Since immutability has not yet been introduced, solutions that mutate the original list (`scores.pop()` or `scores.sort()`) are reasonable and acceptable. However, take the opportunity to start introducing this concept in your comments.

### Common Suggestions

- Use **`sorted()`** over **`sort()`**. `sorted()` returns a _**copy**_ , `sort()` _**mutates in place**_.
Expand Down