-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Store activations in Docs when save_activations is enabled
#11002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b71c604
Store activations in Doc when `store_activations` is enabled
danieldk c3da32b
Change type of `store_activations` to `Union[bool, List[str]]`
danieldk 789a447
Formatting fixes in Tagger
danieldk acf47e8
Support store_activations in spancat and morphologizer
danieldk 42526a6
Make Doc.activations type visible to MyPy
danieldk 8772b9c
textcat/textcat_multilabel: add store_activations option
danieldk 1c9be0d
trainable_lemmatizer/entity_linker: add store_activations option
danieldk 009a960
parser/ner: do not currently support returning activations
danieldk c8a12c5
Extend tagger and senter tests
danieldk 508b96f
Merge remote-tracking branch 'upstream/master' into store-activations
danieldk 3b13f17
Document `Doc.activations` and `store_activations` in the relevant pipes
danieldk df513be
Merge remote-tracking branch 'upstream/v4' into store-activations
danieldk 5eeb2e8
Start errors/warnings at higher numbers to avoid merge conflicts
danieldk 403b1f1
Add `store_activations` to docstrings.
danieldk 288d27e
Merge remote-tracking branch 'upstream/v4' into store-activations
danieldk 51f72e4
Replace store_activations setter by set_store_activations method
danieldk 6e7b958
Use dict comprehension suggested by @svlandeg
danieldk 230264d
Revert "Use dict comprehension suggested by @svlandeg"
danieldk 57caae8
EntityLinker: add type annotations to _add_activations
danieldk ce36f34
_store_activations: make kwarg-only, remove doc_scores_lens arg
danieldk 75d76cb
set_annotations: add type annotations
danieldk c792019
Apply suggestions from code review
1cfbb93
TextCat.predict: return dict
danieldk aea5337
Make the `TrainablePipe.store_activations` property a bool
danieldk 8c2652d
Remove `TrainablePipe.activations`
danieldk 8f84e6e
Add type annotations for activations in predict/set_annotations
danieldk 3937abd
Merge remote-tracking branch 'upstream/v4' into store-activations
danieldk 2290a04
Rename `TrainablePipe.store_activations` to `save_activations`
danieldk cdbda0b
Error E1400 is not used anymore
danieldk 51c87c5
Change wording in API docs after store -> save change
danieldk d245da0
docs: tag (save_)activations as new in spaCy 4.0
danieldk 699a187
Fix copied line in morphologizer activations test
danieldk 6f80e80
Don't train in any test_save_activations test
danieldk cd6e4fa
Rename activations
danieldk 2593dad
Remove unused W400 warning.
danieldk ac5b1fd
Formatting fixes
b828954
Replace "kb_ids" by a constant
danieldk 0bd5730
spancat: replace a cast by an assertion
danieldk 8aba93e
Fix EOF spacing
danieldk a32dd70
Fix comments in test_save_activations tests
danieldk 3a16b7b
Do not set RNG seed in activation saving tests
danieldk fc78ed4
Revert "spancat: replace a cast by an assertion"
danieldk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.