Improve error handling and warnings #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These components back off from batch to single processing in order to handle problematic docs that lead to errors for the transformers `Pipeline` processing (known issues are with "empty" docs like `""` or `" "` but there could potentially be other issues depending on the model). The warnings are a bit noisy, but I'd rather not crash on or skip entire batches containing problematic texts, and if there is no indication, then it's not clear to users why there can be huge speed differences between individual batches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These components back off from batch to single processing in order to handle problematic docs that lead to errors for the transformers
Pipelineprocessing (known issues are with "empty" docs like""or" "but there could potentially be other issues depending on the model).The warnings are a bit noisy, but I'd rather not crash on or skip entire batches containing problematic texts, and if there is no indication, then it's not clear to users why there can be huge speed differences between individual batches.