-
Notifications
You must be signed in to change notification settings - Fork 286
Add with_signpost_interval layer
#711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
536530c
Add with_signpost_interval layer
danieldk e8a73d4
Fix reference in api-layers.md
efd2df0
End message is optional since signpost 0.0.3
danieldk 15a26c7
with_signpost_interval: also wrap init callback
danieldk 2ae435f
docs: we wrap init as well
danieldk fcc6636
Add documentation fixes
danieldk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| from typing import Optional, Callable, Any, Tuple, TypeVar | ||
|
|
||
| from ..compat import has_os_signpost, os_signpost | ||
| from ..model import Model | ||
|
|
||
|
|
||
| _ModelT = TypeVar("_ModelT", bound=Model) | ||
|
|
||
|
|
||
| def with_signpost_interval( | ||
| layer: _ModelT, | ||
| signposter: "os_signpost.Signposter", | ||
| name: Optional[str] = None, | ||
| ) -> _ModelT: | ||
| """Wraps any layer and marks the init, forward and backprop phases using | ||
| signpost intervals for macOS Instruments profiling | ||
|
|
||
| By default, the name of the layer is used as the name of the range, | ||
| followed by the name of the pass. | ||
| """ | ||
| if not has_os_signpost: | ||
| raise ValueError( | ||
| "with_signpost_interval layer requires the 'os_signpost' package" | ||
| ) | ||
|
|
||
| name = layer.name if name is None else name | ||
|
|
||
| orig_forward = layer._func | ||
| orig_init = layer.init | ||
|
|
||
| def forward(model: Model, X: Any, is_train: bool) -> Tuple[Any, Callable]: | ||
| with signposter.use_interval(f"{name} forward"): | ||
| layer_Y, layer_callback = orig_forward(model, X, is_train=is_train) | ||
|
|
||
| def backprop(dY: Any) -> Any: | ||
| with signposter.use_interval(f"{name} backprop"): | ||
| return layer_callback(dY) | ||
|
|
||
| return layer_Y, backprop | ||
|
|
||
| def init(_model: Model, X: Any, Y: Any) -> Model: | ||
| if orig_init is not None: | ||
| with signposter.use_interval(f"{name} init"): | ||
| return orig_init(layer, X, Y) | ||
| else: | ||
| return layer | ||
|
|
||
| layer.replace_callbacks(forward, init=init) | ||
|
|
||
| return layer | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.