ignore non-string routes #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +53,7 @@ methods.forEach(function(method){ | |||
| , self = this; | |||
|
|
|||
| this.namespace(path, function(){ | |||
| path = this._ns.join('/').replace(/\/\//g, '/').replace(/\/$/, '') || '/'; | |||
| path = 'string' != typeof path ? path : this._ns.join('/').replace(/\/\//g, '/').replace(/\/$/, '') || '/'; | |||
There was a problem hiding this comment.
bah, is it spaces or tabs? of course the indentation looks fine in my IDE :)
|
For my purposes I actually can just use my own fork pretty easily, but if you do want these changes, I can rebase the commits or change anything... |
|
At that point I think you should ask @visionmedia for maintainer :). |
|
@visionmedia you can also just move all the express repos to the expressjs org and i can add maintainers and team members |
bulkan
added a commit
to bulkan/express-namespace
that referenced
this pull request
May 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just ignore routes that aren't string. fixes #5, #21