Skip to content

Updating a couple of examples to ES6 syntax #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updating a couple of examples to ES6 syntax #3427

wants to merge 4 commits into from

Conversation

vildevev
Copy link

No description provided.

wesleytodd
wesleytodd approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally against "using es2015 syntax for es2015 syntax sake" PRs. But I think it is worth updating examples now that these things are more of the general standard across the industry.

nikagar4
nikagar4 reviewed Oct 7, 2017
View reviewed changes
@wesleytodd wesleytodd mentioned this pull request Jan 17, 2018
Open
@anlexN

This comment has been minimized.

Sign in to view
@dougwilson dougwilson mentioned this pull request May 15, 2021
Closed
@dougwilson dougwilson force-pushed the master branch 2 times, most recently from eb10dba to 340be0f Compare October 6, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU left review comments

@wesleytodd wesleytodd wesleytodd approved these changes

@nikagar4 nikagar4 nikagar4 left review comments

@ejcheng ejcheng ejcheng approved these changes

@chaqchase chaqchase chaqchase approved these changes

Assignees
No one assigned
Labels
examples needs rebase pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vildevev @anlexN @LinusU @wesleytodd @nikagar4 @ejcheng @chaqchase @dougwilson