ci: add test for windows #1029
Draft
ci: add test for windows #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
32d90f3 to
229e609
Compare
bjohansebas
commented
Mar 14, 2025
raphendyr
reviewed
Mar 17, 2025
bjohansebas
force-pushed
the
windows-test-v2
branch
7 times, most recently
from
a57b64f to
c82db2c
Compare
|
Apparently there's an issue with npm. I have no idea why, but it shouldn't be related to this PR. However, it's something we need to fix if it's affecting the CI. |
bjohansebas
force-pushed
the
windows-test-v2
branch
from
a858dca to
5ddb90a
Compare
raphendyr
reviewed
Apr 9, 2025
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
6c83144 to
3f081b2
Compare
bjohansebas
commented
Apr 11, 2025
package.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| "eslint-plugin-markdown": "3.0.1", | |||
| "express": "4.17.3", | |||
| "mocha": "10.2.0", | |||
| "nyc": "15.1.0", | |||
There was a problem hiding this comment.
To fix a small issue with Windows during installation
bjohansebas
commented
Apr 11, 2025
bjohansebas
force-pushed
the
windows-test-v2
branch
from
27e866d to
8fc9cce
Compare
|
The CI passes 🥳, wow, i really struggled with the old versions of Node.js. |
bjohansebas
commented
Apr 11, 2025
package.json
Outdated
| @@ -39,7 +39,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "lint": "eslint . && node ./scripts/lint-readme.js", | |||
| "test": "./test/support/gencert.sh && mocha --require test/support/env --check-leaks --bail --no-exit --reporter spec test/", | |||
| "test": "bash test/support/gencert.sh && mocha --require test/support/env --check-leaks --reporter spec test/", | |||
There was a problem hiding this comment.
And while we're at it, let's remove '--bail' so we can see which tests fail simultaneously instead of one by one
raphendyr
reviewed
Apr 14, 2025
|
I just tried it now that I have Windows, and this doesn't work. |
bjohansebas
force-pushed
the
windows-test-v2
branch
2 times, most recently
from
a678afe to
bc8e000
Compare
Signed-off-by: Sebastian Beltran <[email protected]>
bjohansebas
force-pushed
the
windows-test-v2
branch
from
bc8e000 to
695134e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related nodejs/citgm#1095 (comment)