Use standardized env variable for the empty message fix#224
Merged
eylles merged 1 commit intoeylles:masterfrom Mar 5, 2026
Merged
Use standardized env variable for the empty message fix#224eylles merged 1 commit intoeylles:masterfrom
eylles merged 1 commit intoeylles:masterfrom
Conversation
Use the standardized XDG_CURRENT_DESKTOP env variabl alongside the legacy DESKTOP_SESSION env variable for the empty message fix
Owner
|
my guess is that either kde plasma or the display manager stopped setting the legacy env var and went with the XDG one only some time between the commit that added the check and now, i do not really follow the development cycle of kde beyond kdenlive tbh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current env variable
DESKTOP_SESSIONis considered legacy and it wasn't even set to the valueplasmaon my system, so using the standardizedXDG_CURRENT_DESKTOPenv variable seems to be a better option. Both are checked with this change btw