Skip to content

optim(watch): don't reset DocumentRegistry b/t watch cycles #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezolenko merged 1 commit into from
Aug 8, 2022
Merged

optim(watch): don't reset DocumentRegistry b/t watch cycles #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
let tsConfigPath: string | undefined;
let servicesHost: LanguageServiceHost;
let service: tsTypes.LanguageService;
let documentRegistry: tsTypes.DocumentRegistry; // keep the same DocumentRegistry between watch cycles
let noErrors = true;
const declarations: { [name: string]: { type: tsTypes.OutputFile; map?: tsTypes.OutputFile } } = {};
const checkedFiles = new Set<string>();
Expand Down Expand Up @@ -98,6 +99,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
pluginOptions.typescript = require("typescript");
}
setTypescriptModule(pluginOptions.typescript);
documentRegistry = tsModule.createDocumentRegistry();

const self: Plugin = {

Expand Down Expand Up @@ -135,8 +137,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
filter = createFilter(context, pluginOptions, parsedConfig);

servicesHost = new LanguageServiceHost(parsedConfig, pluginOptions.transformers, pluginOptions.cwd);

service = tsModule.createLanguageService(servicesHost, tsModule.createDocumentRegistry());
service = tsModule.createLanguageService(servicesHost, documentRegistry);
servicesHost.setLanguageService(service);

// printing compiler option errors
Expand Down