fix(cache): default clean: true when necessary, add extraCacheKeys option

[oscard0m]

Summary

• feat(cache): set options.clean as 'true' by default
• feat(index): add 'extraCacheKeys' option
• fix(cache): apply PR comment fixes

Context

Fixes #228

---

Questions

• Do you know if this approach is correct? It has been a long time since I do not touch rollup and this plugin, so I want to validate this step before getting deeper.

unless the user provided the extraCacheKeys option, we then leave everything up to the user

• Where is the extraCacheKeys option declared? I don't find it. (_originally posted here)

I believe the only two are sourceMapCallback and transformers

• Does this mean I need to do some logic to decide the default value for the clean option depending on these 2 other options?

[agilgur5]

Good questions -- you're on the right track with those 🙂

• Where is the extraCacheKeys option declared? I don't find it. (_originally posted here)

It doesn't exist yet -- this PR would be creating it.

It would be placed in the same index.ts block where you changed clean currently (the Object.assign block sets defaults).

• Set clean option to true by default

It should not be true by default -- see below

• Does this mean I need to do some logic to decide the default value for clean option depending on these 2 other options?

Yep. Here's a quick logic flow:

1. clean is false by default
2. If sourceMapCallback or transformers are passed in, then it should default to true instead
3. If extraCacheKeys is passed in, then it should default back to false again

2 should also log out, telling the user to set extraCacheKeys if they want to re-enable the cache.

[oscard0m]

Applied more changes to the draft.

Now it's not clear to me which part of the code (and how) the extraCacheKeys should be treated.

[agilgur5]

I'm on my phone rn, so only left a few simpler comments for now.

With regard to where to use extraCacheKeys, it would be in the call to object-hash in tscache, i.e. in this block.

[agilgur5]

a few other things from my laptop now