Skip to content

EZP-31086: Redirect based on router, not url alias#1122

Merged
lserwatka merged 1 commit into
ezsystems:1.5from
damianz5:redirect_fix
Sep 14, 2020
Merged

EZP-31086: Redirect based on router, not url alias#1122
lserwatka merged 1 commit into
ezsystems:1.5from
damianz5:redirect_fix

Conversation

@damianz5

@damianz5 damianz5 commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

https://jira.ez.no/browse/EZP-31086

Question Answer
Tickets https://jira.ez.no/browse/EZP-31086
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? should
Doc needed? no
License GPL-2.0

requires:
ezsystems/repository-forms#323

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@damianz5
damianz5 force-pushed the redirect_fix branch 2 times, most recently from 6dbce36 to 7c0d7a6 Compare October 29, 2019 14:09

@webhdx webhdx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay now. One small thing I'd change is UrlRedirectProcessor name, SystemUrlRedirectProcessor is more descriptive.

@tomaszszopinski tomaszszopinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee 2.5 with clone.

@lserwatka
lserwatka merged commit 7518ff4 into ezsystems:1.5 Sep 14, 2020
@lserwatka

Copy link
Copy Markdown
Member

Could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants