Skip to content

Conversation

@glye
Copy link
Member

@glye glye commented Jan 6, 2022

Install Solr 8.11.1 by default, as this includes the upgraded log4j with an important security fix.
For 2.0 branch, eZ Platform v2.5 (as of ezsystems/ezplatform#677 )

Work in progress:

  • Install Solr 8.11.1
  • Readme update is incomplete Good enough. Little need up to date manual install intructions when we anyway refer to the script that does this for us anyway.

@glye glye requested a review from a team January 10, 2022 10:01
@glye glye requested a review from alongosz January 10, 2022 11:32
@alongosz alongosz requested a review from adamwojs January 10, 2022 11:33
@glye
Copy link
Member Author

glye commented Jan 10, 2022

Review fixes: Readme, and removed sample configs.

@glye glye requested a review from alongosz January 10, 2022 12:15
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Requires @adamwojs' review.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@glye
Copy link
Member Author

glye commented Jan 10, 2022

Reverted f14f883 as it breaks the build, probably a regexp actually, so it won't work like that.

Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eXPlatform 2.5 (with ezplatform-solr-search-engine 2.0).

@glye glye merged commit c1da871 into 2.0 Jan 12, 2022
@glye glye deleted the ibx1699_bump_requirements branch January 12, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants