EZP-31238: marked alternative image text as optional to ensure consistence with fieldtype#330
Merged
lserwatka merged 1 commit intoDec 20, 2019
Conversation
konradoboza
approved these changes
Dec 19, 2019
mateuszbieniek
approved these changes
Dec 19, 2019
…tence with fieldtype
micszo
approved these changes
Dec 20, 2019
micszo
left a comment
micszo
left a comment
Member
There was a problem hiding this comment.
QA Approved on eZ Platform EE v2.5.8 with diff.
Member
|
@webhdx could you merge it up? |
Contributor
|
@lserwatka Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.ez.no/browse/EZP-31238
According the
eZ/Publish/Core/FieldType/Image/Type.php:121(https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/FieldType/Image/Type.php#L114) the alternative text is optinal.Creating images without an alternative texts works fine using the repository services or the backend drag&drop image creation. Creating the image through the default content edit requires the alternative text is filled. The reasons for that is that the field is not marked as optional inside the form building:
EzSystems\RepositoryForms\Form\Type\FieldType\ImageFieldType:40.Already approved, discussed it in Slack: