[EZP-32397] Added 'isEditView' variable to DateFieldType View#344
Merged
Conversation
mateuszbieniek
requested review from
adamwojs,
barw4,
konradoboza and
mateuszdebinski
April 6, 2021 09:22
2 tasks
mateuszbieniek
changed the title
mateuszbieniek
changed the title
konradoboza
approved these changes
Apr 6, 2021
mateuszdebinski
approved these changes
Apr 7, 2021
mateuszbieniek
changed the title
ViniTou
approved these changes
Apr 12, 2021
adamwojs
approved these changes
Apr 13, 2021
|
QA approved. |
Member
|
Could you merge it up? |
Contributor
Author
|
Merged up to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://issues.ibexa.co/browse/EZP-32397
The second part of fix: ezsystems/ezplatform-admin-ui#1729
This PR moves some logic from the template https://github.com/ezsystems/ezplatform-admin-ui/blob/v1.5.17/src/bundle/Resources/views/fieldtypes/edit/ezdate.html.twig#L10 to the
lib/Form/Type/FieldType/DateFieldType.phpand adds an additional check for the Content Translate view.