[refactor] carousel 라이브러리 사용 없이 직접 구현 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lecto17
commented
Jun 16, 2025
| {movies.map(({ thumbnail, ranking, description, categories }) => ( | ||
| <li key={ranking}> | ||
| { | ||
| <RankingMovie |
There was a problem hiding this comment.
props를 찢어서 받아야 하는 명확한 이유가 없다면 movie 라는 객체로 하나로 받는게 좋다.
Movie라는 컴포넌트를 만들때에 관한 의사코드가 작성이 됬어야 한다.
모든 것, 가장 작은 것까지 모두 의사 근거로 들어가야 한다.
MyCarousel 명칭이 주는 어감. 내부에서 api를 호출할 것 같은 느낌.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
작업 내용
스크린샷