Skip to content

Change locale test in _getWordCount unit tests to fix CI error #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

fabian-hiller
Copy link
Owner

No description provided.

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 03:40
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valibot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2025 4:03am

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 25, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI error by changing the locale used in a unit test from Swedish ('sv') to Finnish ('fi'). The change ensures the _getWordCount function's locale-dependent behavior is properly tested.

  • Updated locale parameter in word count test from 'sv' to 'fi'

@dosubot dosubot bot added the fix A smaller enhancement or bug fix label Jul 25, 2025
Copy link

pkg-pr-new bot commented Jul 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/valibot@1260

commit: 4ff8858

@fabian-hiller fabian-hiller force-pushed the fix-try-to-solve-strange-ci-error branch from 1446389 to 4ff8858 Compare July 25, 2025 04:00
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 25, 2025
@fabian-hiller fabian-hiller merged commit cdf5fb6 into main Jul 25, 2025
17 checks passed
@fabian-hiller fabian-hiller deleted the fix-try-to-solve-strange-ci-error branch July 25, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A smaller enhancement or bug fix size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant