Remote-filtered async search #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0lg
force-pushed
the
auto-complete-async
branch
from
c9a08df to
c416537
Compare
edgarfgp
reviewed
May 7, 2024
Member
|
@h0lg Thanks for improving this sample. I would be happy to merge as it is . |
edgarfgp
approved these changes
May 7, 2024
…leteBox.ValueMemberBinding in with other Attributes and extensions for reuse
to enable accessing it without access to the model
…d searches by tracking and cancelling them using a separate CTS
Contributor
Author
|
@edgarfgp I have also moved the generic |
Contributor
Author
|
@edgarfgp Thanks for looking into this with me and improving the new extensions by adding parameter doco and simplifying! The merged sample contains a fair amount of code left over from unsuccessful attempts to preserve tree node expansion and/or selection. I'll review and clean them up in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Fabulous Avalonia team,
in this PR I've refactored multi-binding a property into a generic and that of the
AutoCompleteBox.ValueMemberBindinginto a specific extension allowing to set the format and property names used in theMultiBindingand itsConvertereasily.I also added an example of a remote-filtered async search to raise an issue about some erratic behaviour I noticed:
If you try completely new search terms in quick succession, you'll notice that the dropdown sometimes gets populated with results for your previous searches. You'll find some debugging in place that hopefully helps demonstrate what happens.
Thank you for your consideration!