Add support for 11.3.0 features #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Fabulous.Avalonia codebase to add support for Avalonia 11.3.0 features by introducing new properties and corresponding builder extensions across various control modules and updating a package dependency.
- Added ShowSuggestions for styled elements.
- Introduced new spacing and alignment properties in panels (WrapPanel, UniformGrid, Grid, DockPanel) and imaging controls.
- Updated sample pages to demonstrate new properties and bumped the Avalonia.Controls.TreeDataGrid package version.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Fabulous.Avalonia/Views/_StyledElement.fs | Added ShowSuggestions property and corresponding builder extension. |
| src/Fabulous.Avalonia/Views/Panels/WrapPanel.fs | Added ItemsAlignment, ItemSpacing, and LineSpacing properties along with builder overloads. |
| src/Fabulous.Avalonia/Views/Panels/UniformGrid.fs | Introduced RowSpacing and ColumnSpacing properties and extensions. |
| src/Fabulous.Avalonia/Views/Panels/Grid.fs | Added ColumnSpacing and RowSpacing properties and their builder extensions. |
| src/Fabulous.Avalonia/Views/Panels/DockPanel.fs | Added HorizontalSpacing and VerticalSpacing properties and corresponding builder extensions. |
| src/Fabulous.Avalonia/Views/Imaging/Image.fs | Added BlendMode property and builder extension. |
| src/Fabulous.Avalonia/Views/Controls/Primitives/Popup.fs | Added ShouldUseOverlayLayer and TakesFocusFromNativeControl properties and builder extensions. |
| samples/Gallery/Pages/* | Updated sample pages to include new properties. |
| extensions/Fabulous.Avalonia.TreeDataGrid/*.fsproj | Updated the TreeDataGrid package version. |
Comments suppressed due to low confidence (1)
src/Fabulous.Avalonia/Views/Panels/DockPanel.fs:18
- The property name 'HorizontalSpacingSpacing' appears to include a duplicated term. Consider renaming it to 'HorizontalSpacing' to maintain consistency and clarity.
let HorizontalSpacingSpacing = Attributes.defineAvaloniaPropertyWithEquality DockPanel.HorizontalSpacingProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.