-
-
Notifications
You must be signed in to change notification settings - Fork 12
Custom notification content 2 #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edgarfgp
merged 18 commits into
fabulous-dev:main
from
h0lg:custom-notification-content
Nov 16, 2025
Merged
Custom notification content 2 #292
edgarfgp
merged 18 commits into
fabulous-dev:main
from
h0lg:custom-notification-content
Nov 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing file encoding to do so
because NotificationCard is pretty useless otherwise as it can't be passed to a NotificationManager
to reduce example code spaghettification rewording to describe the example
to differentiate different types of notifications
Member
|
@h0lg Thanks for this. Please fix the merge conflicts, so I can have a look |
edgarfgp
reviewed
Nov 16, 2025
edgarfgp
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up for #291 that @edgarfgp got working (thanks!)
simplifying custom-content notification example
pointing out open issue about
NotificationCard'sisClosedparam having no effect