Add new CollectionBuilder constructor using an AttributesBundle
#1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
force-pushed
the
use-attribute-bundle
branch
from
cb0d286 to
01c52d2
Compare
TimLariviere
requested changes
May 15, 2024
Member
TimLariviere
left a comment
TimLariviere
left a comment
There was a problem hiding this comment.
Good addition, This would be useful for more advanced scenario when dealing with CollectionBuilder. I made some comments.
Mainly watch out for the difference between Scalar and AttributeBundle.
Co-authored-by: Timothé Larivière <[email protected]>
Co-authored-by: Timothé Larivière <[email protected]>
edgarfgp
force-pushed
the
use-attribute-bundle
branch
from
88b37c9 to
526198d
Compare
edgarfgp
changed the title
StackList<ScalarAttribute> with AttributesBundleCollectionBuilder constructor using an AttributesBundle
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Fabulous you can't pass a
WidgetBuilderas part of theCollectionBuilderconstructor usingAttributesBundle.Before
After
This PR changes the
CollectionBuilderdefinition to useAttributesBundle.