Fix strings map pinning and detail support Ubuntu version.#55
Merged
Conversation
The file descriptor used to pin the log strings map was not properly initialized. This patch fixes the issue by using the correct file descriptor. Signed-off-by: Quentin Deslandes <qde@naccy.de>
Signed-off-by: Quentin Deslandes <qde@naccy.de>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 23.61% 23.61%
=======================================
Files 39 39
Lines 2719 2719
=======================================
Hits 642 642
Misses 2077 2077 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11, update the documentation to clarify that Ubuntu 23.10+ is required.