[eslint-config-react-app] Property "overrides" is the wrong type #7284

visualcookie · 2019-06-27T14:53:29Z

Desribe the bug

When either trying to save a file or type some code in VSCode, you'll get the following error back:

[Error - 4:41:56 PM] ESLint stack trace:
[Error - 4:41:56 PM] Error: ESLint configuration in .eslintrc.js » eslint-config-react-app is invalid:
	- Property "overrides" is the wrong type (expected array but got `{"files":["**/*.ts","**/*.tsx"],"parser":"@typescript-eslint/parser","parserOptions":{"ecmaVersion":2018,"sourceType":"module","ecmaFeatures":{"jsx":true},"warnOnUnsupportedTypeScriptVersion":true},"plugins":["@typescript-eslint"],"rules":{"default-case":"off","no-dupe-class-members":"off","@typescript-eslint/no-angle-bracket-type-assertion":"warn","no-array-constructor":"off","@typescript-eslint/no-array-constructor":"warn","@typescript-eslint/no-namespace":"error","no-unused-vars":"off","@typescript-eslint/no-unused-vars":["warn",{"args":"none","ignoreRestSiblings":true}],"no-useless-constructor":"off","@typescript-eslint/no-useless-constructor":"warn"}}`).

Did you try recovering your dependencies?

Yes, I did. But didn't work. Even downgraded ESLint back to 5.16.0, same issue.

Which terms did you search for in User Guide?

Not using create-react-app. I'm using Gatsby here.

Environment

  System:
    OS: macOS 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.4.0 - /usr/local/bin/node
    Yarn: 1.17.0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Safari: 12.1.1
  npmPackages:
    gatsby: 2.8.4 => 2.8.4 
    gatsby-image: ^2.1.2 => 2.2.3 
    gatsby-plugin-flow: ^1.1.0 => 1.1.0 
    gatsby-plugin-intl: ^0.2.4 => 0.2.4 
    gatsby-plugin-manifest: ^2.1.1 => 2.2.0 
    gatsby-plugin-module-resolver: ^1.0.3 => 1.0.3 
    gatsby-plugin-offline: ^2.1.1 => 2.2.0 
    gatsby-plugin-react-helmet: ^3.0.12 => 3.1.0 
    gatsby-plugin-sharp: ^2.1.3 => 2.2.1 
    gatsby-plugin-styled-components: ^3.1.0 => 3.1.0 
    gatsby-source-directus7: ^0.8.0 => 0.8.0 
    gatsby-source-filesystem: ^2.0.38 => 2.1.1 
    gatsby-transformer-sharp: ^2.1.21 => 2.2.0 
  npmGlobalPackages:
    gatsby-cli: 2.6.3

// .eslintrc.js

module.exports = {
  globals: {
    __PATH_PREFIX__: true
  },
  extends: [
    "react-app",
    "airbnb",
    "prettier",
    "prettier/react",
    "prettier/flowtype"
  ],
  plugins: ["prettier", "flowtype"],
  rules: {
    "prettier/prettier": [
      "error",
      {
        semi: false,
        trailingComma: "es5",
        printWidth: 100,
        singleQuote: true
      }
    ],
    radix: ["error", "as-needed"],
    "no-console": ["error", { allow: ["error"] }],
    "global-require": "off",
    "jsx-a11y/label-has-associated-control": "off",
    "react/jsx-indent": "off",
    "react/destructuring-assignment": "off",
    "react/default-props-match-prop-types": "off",
    "react/jsx-one-expression-per-line": "off",
    "react/jsx-filename-extension": [
      1,
      {
        extensions: [".js"]
      }
    ],
    "react/prop-types": "off",
    "import/extensions": "off",
    "import/prefer-default-export": "off",
    "flowtype/boolean-style": [2, "boolean"],
    "flowtype/define-flow-type": 1,
    "flowtype/generic-spacing": [2, "never"],
    "flowtype/no-primitive-constructor-types": 2,
    "flowtype/no-types-missing-file-annotation": 2,
    "flowtype/object-type-delimiter": [2, "comma"],
    "flowtype/require-valid-file-annotation": 2,
    "flowtype/space-after-type-colon": [2, "always"],
    "flowtype/space-before-generic-bracket": [2, "never"],
    "flowtype/space-before-type-colon": [2, "never"],
    "flowtype/union-intersection-spacing": [2, "always"],
    "flowtype/use-flow-type": 1,
    "flowtype/valid-syntax": 1,
    "flowtype/type-id-match": [2, "^([A-Z]+[a-z0-9A-Z]*)$"],
    "flowtype/require-return-type": [
      2,
      "always",
      {
        annotateUndefined: "never",
        excludeArrowFunctions: "expressionsOnly"
      }
    ],
    "jsx-a11y/anchor-is-valid": [
      "error",
      {
        components: ["Link", "ButtonLink"],
        specialLink: ["to", "as"],
        aspects: ["noHref", "invalidHref", "preferButton"]
      }
    ]
  },
  settings: {
    "import/resolver": {
      "babel-module": {}
    },
    flowtype: {
      onlyFilesWithFlowAnnotation: false
    }
  }
};

Steps to reproduce

Install Gatsby and initiate a new Gatsby project
Follow these steps to add a custom .eslintrc.js to a Gatsby project

The error should pop right up if you use VSCode for example.

Expected behavior

No error and the code gets formatted.

Actual behavior

Error and the code does not get formatted. Currently nothing from the .eslintrc.js works.

Reproducible demo

Sadly, no reproducible demo, due to the issue being related to the ESLint plugin not create-react-app.

The text was updated successfully, but these errors were encountered:

bugzpodder · 2019-06-27T18:23:55Z

What's the output for yarn why eslint

Grsmto · 2019-06-27T19:33:32Z

This is fixed in #7219

visualcookie · 2019-06-28T05:53:12Z

@bugzpodder VSCode ships with an ESLint plugin, that's mainly why.
@Grsmto Thanks. Seems like Gatsby needs to make the update then?

Ah, nevermind. It looks like it's fixed. Won't get any errors from VSCode anymore and the code formatting also works again.

Closed.

0zguner · 2019-06-28T19:18:50Z

Sadly, this fix has been sitting there for 14 days. Can you release this fix with version 6.0.2 ? @ianschmitz

isabellachen · 2019-07-01T09:19:20Z

I used create-react-app to create my app, and I keep getting this error in vscode - how do I get rid of it? I tried updating react but its the same version as it was when I created the app first a couple of weeks ago. What is the solution to get rid of the error?

kladnik · 2019-07-04T14:34:21Z

Have the same problem with a newly created react app. What is there to do?

mattfreed · 2019-07-04T19:33:51Z

Have close to the same problem, used the create-react-app and get this error in Websotrom 2019.1.3:
Property "overrides" is the wrong type (expected array but got {"files":["**/__tests__/**/*.js","**/*.spec.js","**/*.test.js"],"env":{"jest":true,"jest/globals":true}}).

zifahm · 2019-07-05T09:00:58Z

any workarounds for now?

kladnik · 2019-07-05T09:10:40Z

I'm using ESLint 5.16.0 until it is updated. Works fine.

chibicode · 2019-07-08T17:01:42Z

@ianschmitz This is breaking apps that have the latest ESLint (6.0.x) and "extends": [..., "react-app", ...] on .eslintrc. Would it be possible to just update https://www.npmjs.com/package/eslint-config-react-app as @mzgnr said?

facebook/create-react-app#7284

baitun · 2019-07-09T17:40:30Z

Solution for me was to downgrade eslint from version 6 back to 5 with npm i [email protected]

InSuperposition · 2019-07-09T18:06:52Z

@visualcookie Can you reopen this issue? It seems to be an issue with eslint v6

@kladnik 's suggestion worked for me.

mbulfair · 2019-07-15T18:21:57Z

I'm using this outside of create-react-app as well, and looks like that configuration hasn't been updated in 2 months, until it is, I have to downgrade back to 5x as well.

SampsonCrowley · 2019-07-15T20:41:48Z

+1 for Eslint 6

SampsonCrowley · 2019-07-15T20:51:05Z

There was a merged pull request 3 weeks ago that included fixes for this, but it has not been released

I created eslint-config-react-app-eslint-six in the mean time, just change "react-app" to "react-app-eslint-six" in your eslint extends setting

anton-bot · 2019-07-19T03:36:37Z

@facebook At least can you publish a pre-release version to npm, please.

msitruk · 2019-07-20T21:08:20Z

Same issue with new install today with last version of Webstorm 2019.1.3 i did downgrade to "eslint": "5.16.0" and all is working now waiting for news to go for version 6+

…nfig See: facebook/create-react-app#7284

j-stuckey · 2019-07-25T23:48:31Z

I was having the same problem, I downgraded to [email protected] and I am no longer receiving this error

saifsadi · 2019-08-01T17:17:26Z

I was having the same problem, I downgraded to [email protected] and I am no longer receiving this error

Thanks, It worked for me too.

SampsonCrowley · 2019-08-01T17:24:28Z

@saifsadi yes we know that fixes the problem, because the problems is a breaking change in the latest major version of ESLint.

You can either use eslint-config-react-app-eslint-six to use ESLint 6+, or downgrade ESLint to < 6

likeanormaldude · 2019-08-02T15:55:55Z

Solution for me was to downgrade eslint from version 6 back to 5 with npm i [email protected]

It worked! Thx

SampsonCrowley · 2019-08-02T16:23:17Z

What's the output for yarn why eslint

@bugzpodder VSCode ships with an ESLint plugin, that's mainly why.

@visualcookie yarn why eslint is a command to make yarn output what version is being used and why, not a question

chibicode · 2019-08-02T22:12:35Z

Seems like the new release is coming very soon (comment by @mrmckeb): #7415 (comment)

robersonfox · 2019-08-06T19:42:34Z

It's worked for me npm i -s [email protected]

bugzpodder · 2019-08-07T23:25:48Z

Thanks all, 3.1 will be released this week with this fix.

SampsonCrowley · 2019-08-07T23:32:37Z

@bugzpodder close when it's released?

visualcookie added the issue: bug label Jun 27, 2019

visualcookie mentioned this issue Jun 28, 2019

Gatsby's matchPath still does not work as expected after v2.9.0 gatsbyjs/gatsby#15101

Closed

visualcookie closed this as completed Jun 28, 2019

chibicode added a commit to chibicode/Y-Combinator-for-Non-programmers that referenced this issue Jul 8, 2019

Downgrade eslint until create-react-app is fixed

c453f28

facebook/create-react-app#7284

visualcookie reopened this Jul 11, 2019

nobodyme mentioned this issue Jul 13, 2019

Eslint not producing the error messages when run as a precommit hook using lint-staged lint-staged/lint-staged#661

Closed

genomics-geek added a commit to chopdgd/react-genomix that referenced this issue Jul 22, 2019

Drop eslint to 5.16.0. It is not compatiable with new eslint-react-co…

8bd18fa

…nfig See: facebook/create-react-app#7284

bugzpodder closed this as completed Aug 7, 2019

lock bot locked and limited conversation to collaborators Aug 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eslint-config-react-app] Property "overrides" is the wrong type #7284

[eslint-config-react-app] Property "overrides" is the wrong type #7284

visualcookie commented Jun 27, 2019

bugzpodder commented Jun 27, 2019

Grsmto commented Jun 27, 2019

visualcookie commented Jun 28, 2019 •

edited

Loading

0zguner commented Jun 28, 2019 •

edited

Loading

isabellachen commented Jul 1, 2019

kladnik commented Jul 4, 2019

mattfreed commented Jul 4, 2019

zifahm commented Jul 5, 2019

kladnik commented Jul 5, 2019

chibicode commented Jul 8, 2019 •

edited

Loading

baitun commented Jul 9, 2019

InSuperposition commented Jul 9, 2019

mbulfair commented Jul 15, 2019

SampsonCrowley commented Jul 15, 2019

SampsonCrowley commented Jul 15, 2019 •

edited

Loading

anton-bot commented Jul 19, 2019

msitruk commented Jul 20, 2019

j-stuckey commented Jul 25, 2019

saifsadi commented Aug 1, 2019

SampsonCrowley commented Aug 1, 2019

likeanormaldude commented Aug 2, 2019

SampsonCrowley commented Aug 2, 2019

chibicode commented Aug 2, 2019

robersonfox commented Aug 6, 2019

bugzpodder commented Aug 7, 2019

SampsonCrowley commented Aug 7, 2019

[eslint-config-react-app] Property "overrides" is the wrong type #7284

[eslint-config-react-app] Property "overrides" is the wrong type #7284

Comments

visualcookie commented Jun 27, 2019

Desribe the bug

Did you try recovering your dependencies?

Which terms did you search for in User Guide?

Environment

Steps to reproduce

Expected behavior

Actual behavior

Reproducible demo

bugzpodder commented Jun 27, 2019

Grsmto commented Jun 27, 2019

visualcookie commented Jun 28, 2019 • edited Loading

0zguner commented Jun 28, 2019 • edited Loading

isabellachen commented Jul 1, 2019

kladnik commented Jul 4, 2019

mattfreed commented Jul 4, 2019

zifahm commented Jul 5, 2019

kladnik commented Jul 5, 2019

chibicode commented Jul 8, 2019 • edited Loading

baitun commented Jul 9, 2019

InSuperposition commented Jul 9, 2019

mbulfair commented Jul 15, 2019

SampsonCrowley commented Jul 15, 2019

SampsonCrowley commented Jul 15, 2019 • edited Loading

anton-bot commented Jul 19, 2019

msitruk commented Jul 20, 2019

j-stuckey commented Jul 25, 2019

saifsadi commented Aug 1, 2019

SampsonCrowley commented Aug 1, 2019

likeanormaldude commented Aug 2, 2019

SampsonCrowley commented Aug 2, 2019

chibicode commented Aug 2, 2019

robersonfox commented Aug 6, 2019

bugzpodder commented Aug 7, 2019

SampsonCrowley commented Aug 7, 2019

visualcookie commented Jun 28, 2019 •

edited

Loading

0zguner commented Jun 28, 2019 •

edited

Loading

chibicode commented Jul 8, 2019 •

edited

Loading

SampsonCrowley commented Jul 15, 2019 •

edited

Loading