Skip to content

Upgrade to webpack v2 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Upgrade to webpack v2 #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3fc5fb6
Upgrade to webpack v2
mxstbr Jul 25, 2016
2466010
Remove babel-preset-es2016
mxstbr Jul 25, 2016
8b33bde
Remove carets
mxstbr Jul 25, 2016
c775b39
Reenable UglifyJS source maps
mxstbr Jul 26, 2016
8911fef
resolveLoader.root -> resolveLoader.modules
mxstbr Jul 26, 2016
4b99807
Increment webpack-dev-server version, remove caret
mxstbr Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/babel.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
module.exports = {
cacheDirectory: true,
presets: [
'babel-preset-es2015',
'babel-preset-es2015-webpack',
'babel-preset-es2016',
'babel-preset-react'
].map(require.resolve),
Expand Down
2 changes: 1 addition & 1 deletion config/babel.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

module.exports = {
presets: [
'babel-preset-es2015',
'babel-preset-es2015-webpack',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, it's weird that this isn't es2015-loose. I can't think of any good reason to not use es2015-loose (and correspondingly es2015-loose-native-modules instead of either es2015-native-modules or es2015-webpack) for production.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes all the transforms run in loose mode. It's like es2015-loose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's like es2015-loose.

Haha that's what I'm asking, what is loose mode?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loose mode generates code that is simpler, but less strictly compliant to spec. Compare output:

I'm not aware of any reason to not at least run your production build in loose mode. I'm also not aware of anybody who deliberately uses non-loose mode.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's it, some people would rather be compliant to the spec even though there's more output, etc

'babel-preset-es2016',
'babel-preset-react'
].map(require.resolve),
Expand Down
2 changes: 1 addition & 1 deletion config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = {
// Disable autoprefixer in css-loader itself:
// https://github.com/webpack/css-loader/issues/281
// We already have it thanks to postcss.
loader: ExtractTextPlugin.extract('style', 'css?-autoprefixer!postcss')
loader: ExtractTextPlugin.extract({ fallbackLoader: 'style', loader: 'css?-autoprefixer!postcss' })
},
{
test: /\.json$/,
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"babel-plugin-transform-class-properties": "6.10.2",
"babel-plugin-transform-object-rest-spread": "6.8.0",
"babel-plugin-transform-react-constant-elements": "6.9.1",
"babel-preset-es2015": "6.9.0",
"babel-preset-es2015-webpack": "^6.4.2",
"babel-preset-es2016": "6.11.3",
"babel-preset-react": "6.11.1",
"chalk": "1.1.3",
Expand All @@ -46,7 +46,7 @@
"eslint-plugin-import": "1.10.3",
"eslint-plugin-jsx-a11y": "2.0.1",
"eslint-plugin-react": "5.2.2",
"extract-text-webpack-plugin": "1.0.1",
"extract-text-webpack-plugin": "^2.0.0-beta.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed otherwise webpack fails with an error.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must remove caret because it's in beta and api can be changed.
I faced with this today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that was an accident! Good catch!

"file-loader": "0.9.0",
"fs-extra": "^0.30.0",
"html-webpack-plugin": "2.22.0",
Expand All @@ -56,7 +56,7 @@
"rimraf": "2.5.3",
"style-loader": "0.13.1",
"url-loader": "0.5.7",
"webpack": "1.13.1",
"webpack": "^2.1.0-beta.20",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also caret here

"webpack-dev-server": "1.14.1"
},
"devDependencies": {
Expand Down