Skip to content

Change CSS preprocessors doc for composability #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change CSS preprocessors doc for composability #2018

wants to merge 1 commit into from

Conversation

diagramatics
Copy link

Since there are dupes in watch-css we can just run the same command written in the build-css npm script, escape the following params with -- and specify the params for build-css. I always think this is better, but obviously the "escaping" part of escaping params so they don't get passed to npm but to the script is confusing, but let me know if this fits the project.

Since there are dupes in `watch-css` we can just run the same command written in the `build-css` npm script, escape the following params with `--` and specify the params for `build-css`.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jan 9, 2018

Sorry we didn't review the PR in time. The instructions have changed so this doesn't merge cleanly now. Feel free to resubmit if you'd like! Thanks.

@gaearon gaearon closed this Jan 9, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants