Skip to content

Change CSS preprocessors doc for composability #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Change CSS preprocessors doc for composability #4379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5178c52
Change CSS preprocessors doc for composability
diagramatics Apr 30, 2018
a3278e3
Merge branch 'next' into patch-1
diagramatics Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ Then in `package.json`, add the following lines to `scripts`:
```diff
"scripts": {
+ "build-css": "node-sass-chokidar src/ -o src/",
+ "watch-css": "node-sass-chokidar src/ -o src/ --watch",
+ "watch-css": "npm run build-css -- --watch",
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test --env=jsdom",
Expand All @@ -637,7 +637,7 @@ To enable importing files without using relative paths, you can add the `--incl

```
"build-css": "node-sass-chokidar --include-path ./node_modules src/ -o src/",
"watch-css": "node-sass-chokidar --include-path ./node_modules src/ -o src/ --watch",
"watch-css": "npm run build-css -- --watch",
```

This will allow you to do imports like
Expand Down Expand Up @@ -666,7 +666,7 @@ Then we can change `start` and `build` scripts to include the CSS preprocessor c
```diff
"scripts": {
"build-css": "node-sass-chokidar src/ -o src/",
"watch-css": "npm run build-css && node-sass-chokidar src/ -o src/ --watch --recursive",
"watch-css": "npm run build-css && npm run build-css -- --watch --recursive",
- "start": "react-scripts start",
- "build": "react-scripts build",
+ "start-js": "react-scripts start",
Expand Down