Revert "Add loader for .graphql files (#3909)" #5076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For brevity, the macro is https://github.com/evenchange4/graphql.macro Usage: import { loader } from 'graphql.macro';
const A = loader('./assets/graphql.graphql');Thanks @Timer! |
|
Changes in a |
|
@glennreyes Please file a new issue. |
danilobuerger
added a commit
to danilobuerger/graphql-tag
that referenced
this pull request
Jan 15, 2019
Initial loader support in CRA2 was reverted here: facebook/create-react-app#5076 Using the macro https://github.com/evenchange4/graphql.macro the same can be achieved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts adding explicit support for
.graphqlfiles following #4893.This behavior is easily accomplished via a babel macro, and it more explicit than getting an arbitrary-version AST object from a text file.