Skip to content

Added tslint-loader to webpack config, added tslint.json to typescrip… #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

adriankremer
Copy link

@adriankremer adriankremer commented Dec 5, 2018

Added tslint-loader to webpack config, added tslint.json to typescript template since there is currently no way to set this by package.json alá eslintConfig for IDE support

I have added tslint-loader conditionally by "useTypeScript" to the webpack-config and a tslint.json (as used before by "react-scripts-ts").

i have used a rest/spread operator which might be a problem > node 6.4.0 (https://node.green/#ES2015-syntax-rest-parameters)

i have also added a tslint.json to the --typescript template root

Tested on MacOS High Sierra
Node: v8.11.2
NPM: v5.6.0

image

…t template since there is currently no way to set this by package.json alá eslintConfig for IDE support
@netlify
Copy link

netlify bot commented Dec 5, 2018

Deploy preview for create-react-app ready!

Built with commit 8e7984c

https://deploy-preview-5969--create-react-app.netlify.com

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

ianschmitz commented Dec 5, 2018

Thanks for your contribution. We already have a PR up for this over at #5697.

There's still work to be done over there. Feel free to see if you can help out!

@ianschmitz ianschmitz closed this Dec 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants